[Enhancement] Respect `files`/`include` in tsconfig.json

[Laurence Dougal Myers]

I'm working on a project which has noImplicitAny: false in tsconfig.json. I'd like to add a separate config file tsconfig.strict.json, with noImplicitAny: true, so I can type check a subset of files, and incrementally improve the codebase.

It looks like vue-script-tsc will pick up all .vue files in src/, regardless of what's defined in the files or include properties in tsconfig.json.

Would it be possible to respect the config's files/includes when discovering the files to type check? I think it could just be a matter of "filtering" the files with glob (or similar).

[Ben Jones]

@laurence-myers Thanks for this suggestion, this a good use case and one I want to add support for. I wonder if TS will report the files it matches with a .vue extension even if it doesn't end up reading them. If so this may actually be a simple fix.

One thing to clarify, TS will by default pick up dependencies and check them too. So if you have the following structure:

src/
  - clean/
    - ComponentClean.vue
  - to-update/
    - ComponentDirty.vue

If you are importing ComponentDirty into ComponentClean, even if you only ran the type check on the clean directory it would still fail because ComponentDirty is a dependency. I think it's best to keep this caveat as it is more in line with how TS does type checking, if instead you wanted to ignore those dependencies too this would have to be under a new flag or something.

[Laurence Dougal Myers]

Great! I'd be happy with that dependency approach. I'd like to specify one or more "clean" root files, so all imported files should also be clean. 🙂

…

On Thu, 30 Sep. 2021, 10:49 pm Ben Jones, ***@***.***> wrote: @laurence-myers <https://github.com/laurence-myers> Thanks for this suggestion, this a good use case and one I want to add support for. I wonder if TS will report the files it matches with a .vue extension even if it doesn't end up reading them. If so this may actually be a simple fix. One thing to clarify, TS will by default pick up dependencies and check them too. So if you have the following structure: src/ - clean/ - ComponentClean.vue - to-update/ - ComponentDirty.vue If you are importing ComponentDirty into ComponentClean, even if you only ran the type check on the clean directory it would still fail because ComponentDirty is a dependency. I think it's best to keep this caveat as it is more in line with how TS does type checking, if instead you wanted to ignore those dependencies too this would have to be under a new flag or something. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQK4MEXQVVZJH6KJ5IS5D3UERMFPANCNFSM5FBJDQRA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[github-actions]

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀