poldrack / narps

Output directory concat_thresh remains empty after my local execution of the pipeline. Tracking it through the code, I'm not sure how it gets used in create_thresh_overlap_images:

narps/ImageAnalyses/narps.py

Lines 589 to 591 in c604014

    
           concat_file = os.path.join( 
        
               self.dirs.dirs['concat_thresh'], 
        
               'hypo%d.nii.gz' % hyp)

I must be missing something since create_thresh_overlap_images still produces a plausible result, but can't figure out what.

this took me a bit to figure out. I think what is happening is that self.dirs.dirs['concat_thresh'] is getting renamed to .../thresh_concat_resampled at line 529. so it ends up violating the unwritten assumption here that the dictionary key matches the actual directory name. I will rewrite this so that the dict keys always match the directory name, to prevent confusion.

ok, should be fixed in commits leading up to 3a3218e

	concat_file = os.path.join(
	self.dirs.dirs['concat_thresh'],
	'hypo%d.nii.gz' % hyp)

concat_thresh directory