QA tools
till opened this issue · comments
We use rubocop and foodcritic extensively. When I imported this cookbook into our tree, I received a couple notes about failures and violations.
I was wondering if I should work on ignoring these or if I should issue a PR which fixes the violations and includes these tools on future Travs-CI runs.
If they are actual bugs, sure, but I don't follow those default styles in all cases if thats what you mean.
@coderanger I realize you don't follow them, I was wondering if you'd be open to discussing this.
E.g. foodcritic is very helpful to maintain consistency and squash potential bugs/issues in chef. rubocop enforces a consistent style, etc.. But it looks like you already closed this conversation.
@till Like I said, I'm far better at enforcing a good style than Rubocop is :-)
@coderanger tools are more scalable though. :)
But anyway, I just ignored your cookbook inside our CI setup.