upgrade Yarn to v4.0, Node to v20 and fix the docker image test
igoychev opened this issue · comments
Which area(s) of Podkrepi.bg are affected? (leave empty if unsure)
No response
Describe the feature you'd like to request
Two things to upgrade and one to fix:
- Yarn 4.0 is out and will be great to upgrade
- The frontend is updated to Node v20, so let's update in Docker image to v20 too
- The github action that tests the docker images is building the master instead of the PR code, so it needs to be fixed to use the context from the git checkout in the previous step(see screenshot below)
![Screenshot 2023-10-26 at 10 47 51](https://private-user-images.githubusercontent.com/7055304/278253038-0a9d4ac9-ecd2-45fe-aaf9-a4319e927376.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyNzg0MjYsIm5iZiI6MTcyNDI3ODEyNiwicGF0aCI6Ii83MDU1MzA0LzI3ODI1MzAzOC0wYTlkNGFjOS1lY2QyLTQ1ZmUtYWFmOS1hNDMxOWU5MjczNzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjFUMjIwODQ2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjA1MmFkNjg5MmQ1ZDIwYWZiMmZhNTU1ODc4Y2E4MTNlNGFiNzMwZDgzNjhhZmFjZWU5ZGE4ZWMwMTY5NjkzNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.c3ViKBGvcGMZK5krdNr4LtnB2SioRoHB4H1pztYF86k)
Describe the solution you'd like
The fix of the Docker checkout action is to add "context: ." as per the path context docs after this line here:
api/.github/workflows/security-checks.yml
Line 21 in 6d1bd9f
Describe alternatives you've considered
No response