Remove user avatar from Toolbar

Question

Remove user avatar from Toolbar

veyndan opened this issue 6 years ago · comments

The toolbar with the avatar looks overly cluttered, and is reminiscent of a time pre-lollipop where having the application icon and title was common. The practice of having an application icon and title is discouraged according to the docs:

The use of application icon plus title as a standard layout is discouraged on API 21 devices and newer.

I know this isn't the application icon but the cons of having the avatar icon I feel is similar to that of the application icon.

Looking at other apps with the idea of users e.g. Facebook, Instagram, Twitter; none of them include the user icon when you are scrolling the feed, they just include the username.

Note that I'm suggesting of removing all avatar icons from the toolbar, not just the ones on the user page (e.g. also the project page, gist page).

Current design	Proposed design

John Michael Farina · Answer 1 · Tue Apr 03 2018 23:20:30 GMT+0800 (China Standard Time)

@veyndan mind if I give this issue a go?

Veyndan Stuart · Answer 2 · Wed Apr 04 2018 00:03:14 GMT+0800 (China Standard Time)

Thanks for the interest in contributing! I'd like some feedback from @Meisolsson about this change as at the moment I'm not sure if this is a change that would be desired. If he comments saying he's onboard with the change as well, then please give the issue a go!

John Michael Farina · Answer 3 · Wed Apr 04 2018 00:43:23 GMT+0800 (China Standard Time)

Not a problem at all, I'll keep my eye out and wait for the decision. I'm always up for contributing so I'll keep an eye out on the issues portion of this repo.

Henrik Olsson · Answer 4 · Wed Apr 11 2018 23:30:55 GMT+0800 (China Standard Time)

It's good to remove it now, but later we probably want something like with a user info and avatars in a AppBarLayout. But yeah, removing it sounds good.