pocka / slack-message-parser

Parser for Slack message format

Home Page:https://pocka.github.io/slack-message-parser/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incomplete punctuation mark matching

luka-n opened this issue · comments

commented

For bold/italic/strike, currently only period and comma match as punctuation. I'm not sure how to cover all possible punctuation here.

I was looking at this:

http://xregexp.com/plugins/

It has a matcher for all punctuation characters in unicode.

For bold/italic/strike, currently only period and comma match as punctuation.

Could you give me a list of characters you know treated as punctuations in Slack?

I'm not sure how to cover all possible punctuation here.

We don't need to cover all punctuations at now, IMO.
Since there is no detailed document about Slack's message syntax, my stance on message parsing is "fix when someone pointed out "

commented

That's a reasonable approach. For now I'd reckon at least add question and exclamation marks.

fixed in v1.0.5