add to conda-forge

Question

add to conda-forge

martibosch opened this issue 3 years ago · comments

Hello,

I am trying to add the detectree library (which uses PyMaxflow) to conda-forge, however that requires PyMaxflow to also be in conda-forge. It should be very easy to do so (e.g., using grayskull as in grayskull pypi PyMaxflow).

I am happy to help if that interests you - it is actually quite easy. Let me know what you think. Best,
Martí

Martí Bosch · Answer 1 · Mon May 31 2021 21:04:13 GMT+0800 (China Standard Time)

I have submitted a PR with a conda recipe so that the package can be installed from conda-forge.

pmneila · Answer 2 · Tue Jun 01 2021 10:02:54 GMT+0800 (China Standard Time)

Hi, @martibosch,

That's great, thank you for your work!

Just a minor comment: the core of PyMaxflow is licensed under the GPL 3, so I think PyMaxflow should also use GPL 3, not the GPL 1. Could you please update the license file accordingly?

Martí Bosch · Answer 3 · Tue Jun 01 2021 14:15:48 GMT+0800 (China Standard Time)

Hello @pmneila,

I have amended the commit by changing GPL 1 for GPL 3.

Let me know if any further amendments are required. Best,
Martí

Martí Bosch · Answer 4 · Thu Jun 10 2021 04:49:24 GMT+0800 (China Standard Time)

closing as the PR has been merged.