pmgbergen / porepy

Python Simulation Tool for Fractured and Deformable Porous Media

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BUG: Compatibility check between scheduled and simulated times

jhabriel opened this issue · comments

When comparing simulated and scheduled times, due to floating point arithmetic, sanity checks fail when they are supposed to pass.

We need to improve the sanity check by introducing some type of tolerance and update the unit tests accordingly.

Yes, something like np.all(np.isclose(test_values, known_values)) is much more robust than test_values == known_values

Indeed. I'm working on it.