preload_basic_commands test fails when executed from root
marcinslusarz opened this issue · comments
It takes write permission from a file and expects overwriting it should fail.
Those tests should not be run as root.
I agree. We just need to detect it and refuse to run tests at all (I think it's preferred) or skip some of them.
Yup, libpmemfile should just abort when root.
libpmemfile tests, not libpmemfile!
Well, both, that is the best.
Then we wouldn't be able to test libpmemfile with pjdfstest. And I don't see any problem with handling root correctly. We already support chown, capabilities affecting file APIs, setuid & co.