Unstable libpmempool_feature test results
grom72 opened this issue · comments
Tomasz Gromadzki commented
ISSUE: Unstable libpmempool_feature test results
Environment Information
- PMDK package version(s):
- OS(es) version(s):
- ndctl version(s):
- kernel version(s):
- compiler, libraries, packaging and other related tools version(s):
Please provide a reproduction of the bug:
How often bug is revealed: (always, often, rare):
Actual behavior:
Expected behavior:
Details
Additional information about Priority and Help Requested:
Are you willing to submit a pull request with a proposed change? (Yes, No)
Requested priority: (Showstopper, High, Medium, Low)
Tomasz Gromadzki commented
The problem is in this part of the bash script libpmempool_feature/common.sh
:
...
ERROR_PATTERN="<1> \\[feature.c:.*\\]"
...
function libpmempool_feature_query_abnormal() {
# query feature
expect_abnormal_exit ./libpmempool_feature$EXESUFFIX $POOL q $1
if [ -f "$PMEMPOOL_LOG_FILE" ]; then
cat $PMEMPOOL_LOG_FILE | grep "$ERROR_PATTERN" >> $LOG
fi
}
New logging implementation ignores PMEMPOOL_LOG_FILE
and have different logging formats:
Jan 25 22:42:12.002905 [559030] *ERROR* feature.c: 133: features_check: invalid features detected: {compat 0xfe, incompat 0x0, ro_compat 0x0}
Jan 25 22:42:12.002924 [559030] *ERROR* feature.c: 201: poolset_open: invalid features - replica #0 part #0
instead of:
<libpmempool>: <1> [feature.c:133 features_check] invalid features detected: {compat 0x0, incompat 0x0, ro_compat 0xfe}
<libpmempool>: <1> [feature.c:201 poolset_open] invalid features - replica #0 part #0