Obsolete persistent locks after removing FreeBSD support
grom72 opened this issue · comments
Tomasz Gromadzki commented
ISSUE: Obsolete persistent locks after removing FreeBSD support
Environment Information
- PMDK package version(s): 1.13.1
Please provide a reproduction of the bug:
PMEMmutex_internal *mutex_head;
PMEMrwlock_internal *rwlock_head;
PMEMcond_internal *cond_head;
Locks are no longer needed after FreeBSD support but must stay as they are part of the pmempool header.
Tomasz Gromadzki commented
Removal of bsd_u from padded_pmemmutex to be considered:
typedef union padded_pmemmutex {
char padding[_POBJ_CL_SIZE];
struct {
uint64_t runid;
union {
os_mutex_t mutex;
struct {
void *bsd_mutex_p;
union padded_pmemmutex *next;
} bsd_u;
} mutex_u;
} pmemmutex;
} PMEMmutex_internal;