75: test suite is failing in `ndctl:cxl / cxl-xor-region.sh` unit
kloczek opened this issue · comments
Looks like something is wrong with test suite
+ cd ndctl-75
+ /usr/bin/meson test -C x86_64-redhat-linux-gnu --num-processes 48 --print-errorlogs
ninja: no work to do.
ninja: Entering directory `/home/tkloczko/rpmbuild/BUILD/ndctl-75/x86_64-redhat-linux-gnu'
[1/56] Generating version.h with a custom command
1/28 ndctl:ndctl / libndctl SKIP 0.01s exit status 77
2/28 ndctl:ndctl / dsm-fail SKIP 0.01s exit status 77
3/28 ndctl:ndctl / create.sh SKIP 0.04s exit status 77
4/28 ndctl:ndctl / clear.sh SKIP 0.04s exit status 77
5/28 ndctl:ndctl / pmem-errors.sh SKIP 0.04s exit status 77
6/28 ndctl:dax / daxdev-errors.sh SKIP 0.04s exit status 77
7/28 ndctl:dax / multi-dax.sh SKIP 0.04s exit status 77
8/28 ndctl:ndctl / btt-check.sh SKIP 0.04s exit status 77
9/28 ndctl:ndctl / label-compat.sh SKIP 0.04s exit status 77
10/28 ndctl:ndctl / sector-mode.sh SKIP 0.02s exit status 77
11/28 ndctl:ndctl / inject-error.sh SKIP 0.04s exit status 77
12/28 ndctl:ndctl / btt-errors.sh SKIP 0.05s exit status 77
13/28 ndctl:ndctl / hugetlb SKIP 0.01s exit status 77
14/28 ndctl:ndctl / btt-pad-compat.sh SKIP 0.02s exit status 77
15/28 ndctl:ndctl / ack-shutdown-count-set SKIP 0.01s exit status 77
16/28 ndctl:ndctl / rescan-partitions.sh SKIP 0.04s exit status 77
17/28 ndctl:ndctl / inject-smart.sh SKIP 0.04s exit status 77
18/28 ndctl:ndctl / monitor.sh SKIP 0.04s exit status 77
19/28 ndctl:ndctl / max_extent_ns SKIP 0.04s exit status 77
20/28 ndctl:ndctl / pfn-meta-errors.sh SKIP 0.04s exit status 77
21/28 ndctl:ndctl / track-uuid.sh SKIP 0.02s exit status 77
22/28 ndctl:cxl / cxl-topology.sh SKIP 0.02s exit status 77
23/28 ndctl:cxl / cxl-region-sysfs.sh SKIP 0.02s exit status 77
24/28 ndctl:cxl / cxl-labels.sh SKIP 0.02s exit status 77
25/28 ndctl:cxl / cxl-create-region.sh SKIP 0.02s exit status 77
26/28 ndctl:cxl / cxl-xor-region.sh FAIL 0.02s exit status 1
>>> LD_LIBRARY_PATH=/home/tkloczko/rpmbuild/BUILD/ndctl-75/x86_64-redhat-linux-gnu/cxl/lib:/home/tkloczko/rpmbuild/BUILD/ndctl-75/x86_64-redhat-linux-gnu/daxctl/lib:/home/tkloczko/rpmbuild/BUILD/ndctl-75/x86_64-redhat-linux-gnu/ndctl/lib TEST_PATH=/home/tkloczko/rpmbuild/BUILD/ndctl-75/x86_64-redhat-linux-gnu/test DATA_PATH=/home/tkloczko/rpmbuild/BUILD/ndctl-75/test MALLOC_PERTURB_=31 NDCTL=/home/tkloczko/rpmbuild/BUILD/ndctl-75/x86_64-redhat-linux-gnu/ndctl/ndctl DAXCTL=/home/tkloczko/rpmbuild/BUILD/ndctl-75/x86_64-redhat-linux-gnu/daxctl/daxctl /bin/bash /home/tkloczko/rpmbuild/BUILD/ndctl-75/test/cxl-xor-region.sh
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
stdout:
test/cxl-xor-region.sh: failed at line 15
stderr:
+ trap 'err $LINENO' ERR
+ check_prereq jq
+ command -v jq
+ modprobe -r cxl_test
modprobe: FATAL: Module cxl_test not found.
++ err 15
+++ basename /home/tkloczko/rpmbuild/BUILD/ndctl-75/test/cxl-xor-region.sh
++ echo test/cxl-xor-region.sh: failed at line 15
++ '[' -n '' ']'
++ exit 1
―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
27/28 ndctl:ndctl / nfit-security.sh SKIP 0.05s exit status 77
28/28 ndctl:cxl / cxl-security.sh SKIP 0.05s exit status 77
Summary of Failures:
26/28 ndctl:cxl / cxl-xor-region.sh FAIL 0.02s exit status 1
Ok: 0
Expected Fail: 0
Fail: 1
Unexpected Pass: 0
Skipped: 27
Timeout: 0
@kloczek Thanks, I see the bug in the unit test where it should skip instead of fail if cxl_test is not available.
Was this report from some sort of automated testing?
Yes it was part of the build log of building rpm package.
Ah got it - what for / where are these builds happening - just out of curiosity
On my private build systems 😋
If you need more details feel free to ask 😄
So something is missing in in build env that this unit is failing?
Looks like you don't have the test modules so you are not really testing anything, and that one test has broken boilerplate and instead of getting skipped it reports an error.
Hmm .. what you mean "test modules"? 🤔
Hmm .. why test suite resources needs to be installed and rest is not done during make check? 🤔
Hmm .. why test suite resources needs to be installed and rest is not done during
make check? thinking
The unit tests are not meant for automated build environments. They require the ability to build and install kernel modules in the test system. So the expectation is that the unit tests are always skipped during package builds. In other words the unit tests are more designed for unit testing the user/kernel interface than the tool and library itself.
@kloczek This should fix it - https://lore.kernel.org/all/20230112-vv-xor-test-skip-v1-1-92ddc619ba6c@intel.com/
Did you need a point release with this fix or have you worked around it? The Fedora packaging builds either don't trigger this or don't care, so I was going to skip doing a point release just for this unless someone would really like it.
Will tet that later because my build servers are now under maintanance.
No I don't need that ASP. As long as it is only test suite issue it can wait 😄
Thank you 👍
Closing now that v76 is out with the fix.