pmem / ndctl

A "device memory" enabling project encompassing tools and libraries for CXL, NVDIMMs, DAX, memory tiering and other platform memory device topics.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Meson issues

tristan957 opened this issue · comments

All the root*dir logic is unnecessary. Subprojects inherit the standard directories from the root project. I don't really know why there is an iniparserdir option. Please remove it because if I have a prefix in the root project of /opt/cxl-reskit, then Meson fails looking for the iniparser headers in /opt/cxl-reskit/include because the prefix doesn't exist.

if get_option('systemd').enabled()
  systemd = dependency('systemd', required : true)
  systemdunitdir = systemd.get_pkgconfig_variable('systemdsystemunitdir')
  udev = dependency('udev', required : true)
  udevdir = udev.get_pkgconfig_variable('udevdir')
  udevrulesdir = udevdir / 'rules.d'
endif

You are effectively making -Dsystemd a boolean instead of a feature with this logic.

Please use meson.override_find_program() and meson.override_dependency() as necessary for an binaries and dependencies.

These are just a few issues that I have had trying to consume this build system.

I can refer you to a Meson maintainer within Intel if help is needed.