ndctl test suite firmware-update.sh failed
yizhanglinux opened this issue · comments
Hello
I found this failure during ndctl test suite, could anyone help check whether it's expected?
:: [ 12:03:22 ] :: [ BEGIN ] :: Running 'meson test -C build --no-suite cxl'
ninja: Entering directory `/root/rpmbuild/BUILD/ndctl-74/build'
[1/56] Generating version.h with a custom command
1/23 ndctl:ndctl / libndctl OK 3.92s
2/23 ndctl:ndctl / dsm-fail OK 0.35s
3/23 ndctl:ndctl / create.sh OK 0.61s
4/23 ndctl:ndctl / clear.sh OK 14.86s
5/23 ndctl:ndctl / pmem-errors.sh OK 14.59s
6/23 ndctl:dax / daxdev-errors.sh OK 12.49s
7/23 ndctl:dax / multi-dax.sh OK 0.51s
8/23 ndctl:ndctl / btt-check.sh OK 5.23s
9/23 ndctl:ndctl / label-compat.sh OK 0.57s
10/23 ndctl:ndctl / sector-mode.sh OK 1.14s
11/23 ndctl:ndctl / inject-error.sh OK 13.90s
12/23 ndctl:ndctl / btt-errors.sh OK 23.25s
13/23 ndctl:ndctl / hugetlb OK 1.28s
14/23 ndctl:ndctl / btt-pad-compat.sh OK 1.39s
15/23 ndctl:ndctl / firmware-update.sh FAIL 14.28s exit status 1
>>> NDCTL=/root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl DAXCTL=/root/rpmbuild/BUILD/ndctl-74/build/daxctl/daxctl TEST_PATH=/root/rpmbuild/BUILD/ndctl-74/build/test MALLOC_PERTURB_=57 DATA_PATH=/root/rpmbuild/BUILD/ndctl-74/test /root/rpmbuild/BUILD/ndctl-74/test/firmware-update.sh
16/23 ndctl:ndctl / ack-shutdown-count-set OK 0.02s
17/23 ndctl:ndctl / rescan-partitions.sh OK 7.07s
18/23 ndctl:ndctl / inject-smart.sh OK 1.06s
19/23 ndctl:ndctl / monitor.sh OK 43.90s
20/23 ndctl:ndctl / max_extent_ns OK 0.76s
21/23 ndctl:ndctl / pfn-meta-errors.sh OK 14.88s
22/23 ndctl:ndctl / track-uuid.sh OK 0.51s
23/23 ndctl:ndctl / security.sh OK 1.54s
Ok: 22
Expected Fail: 0
Fail: 1
Unexpected Pass: 0
Skipped: 0
Timeout: 0
=================================== 15/23 ====================================
test: ndctl:ndctl / firmware-update.sh
start time: 16:04:57
duration: 14.28s
result: exit status 1
command: NDCTL=/root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl DAXCTL=/root/rpmbuild/BUILD/ndctl-74/build/daxctl/daxctl TEST_PATH=/root/rpmbuild/BUILD/ndctl-74/build/test MALLOC_PERTURB_=57 DATA_PATH=/root/rpmbuild/BUILD/ndctl-74/test /root/rpmbuild/BUILD/ndctl-74/test/firmware-update.sh
----------------------------------- stdout -----------------------------------
[
{
"provider":"nfit_test.0",
"dev":"ndbus0",
"scrub_state":"idle",
"firmware":{
"activate_method":"suspend",
"activate_state":"idle"
}
}
]
test/firmware-update.sh: failed at line 65
----------------------------------- stderr -----------------------------------
+ rc=77
+ dev=
+ image=update-fw.img
++ dirname /root/rpmbuild/BUILD/ndctl-74/test/firmware-update.sh
+ . /root/rpmbuild/BUILD/ndctl-74/test/common
++ '[' -z /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl ']'
++ '[' -z /root/rpmbuild/BUILD/ndctl-74/build/daxctl/daxctl ']'
++ '[' -z ']'
++ '[' -f ../cxl/cxl ']'
++ '[' -f ./cxl/cxl ']'
++ '[' -x ./cxl/cxl ']'
++ export CXL=./cxl/cxl
++ CXL=./cxl/cxl
++ '[' -z /root/rpmbuild/BUILD/ndctl-74/build/test ']'
++ NFIT_TEST_BUS0=nfit_test.0
++ NFIT_TEST_BUS1=nfit_test.1
++ ACPI_BUS=ACPI.NFIT
++ E820_BUS=e820
+ trap 'err $LINENO' ERR
+ check_min_kver 4.16
+ local ver=4.16
++ uname -r
+ : 6.0.0-0.rc4.53e99dcff61e.32.test.eln.x86_64
+ '[' -n 4.16 ']'
++ echo -e '4.16\n6.0.0-0.rc4.53e99dcff61e.32.test.eln.x86_64'
++ sort -V
++ head -1
+ [[ 4.16 == \4\.\1\6 ]]
+ modprobe nfit_test
+ fwupd_reset
+ reset
+ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl disable-region -b nfit_test.0 all
disabled 2 regions
+ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl init-labels -f -b nfit_test.0 all
initialized 4 nmems
+ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl enable-region -b nfit_test.0 all
enabled 2 regions
+ '[' -f update-fw.img ']'
+ detect
+ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl wait-scrub nfit_test.0
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl list -b nfit_test.0 -F
++ jq -r '.[0].firmware.activate_method'
+ fwa=suspend
+ '[' suspend = suspend ']'
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl list -b nfit_test.0 -D
++ jq length
+ count=4
+ '[' 4 -eq 4 ']'
+ rc=1
+ do_tests
+ truncate -s 196608 update-fw.img
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl update-firmware -b nfit_test.0 -f update-fw.img all
Error: update firmware: nmem2: arm aborted, tripped overflow
updated 4 nmems.
+ json='[
{
"dev":"nmem1",
"id":"cdab-0a-07e0-feffffff",
"handle":1,
"phys_id":1,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"armed"
}
},
{
"dev":"nmem3",
"id":"cdab-0a-07e0-fefeffff",
"handle":257,
"phys_id":3,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"armed"
}
},
{
"dev":"nmem0",
"id":"cdab-0a-07e0-ffffffff",
"handle":0,
"phys_id":0,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"armed"
}
},
{
"dev":"nmem2",
"id":"cdab-0a-07e0-fffeffff",
"handle":256,
"phys_id":2,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"idle"
}
}
]'
++ jq 'map(select(.firmware.activate_state == "armed")) | length'
+ count=3
+ '[' 3 -eq 3 ']'
++ jq 'map(select(.firmware.activate_state == "idle")) | length'
+ count=1
+ '[' 1 -eq 1 ']'
++ jq -r '.[] | select(.firmware.activate_state == "idle").dev'
+ dev=nmem2
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl update-firmware -b nfit_test.0 nmem2 -A --force
updated 1 nmem.
+ json='[
{
"dev":"nmem2",
"id":"cdab-0a-07e0-fffeffff",
"handle":256,
"phys_id":2,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"armed"
}
}
]'
++ jq -r '.[0].firmware.activate_state'
+ state=armed
+ '[' armed = armed ']'
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl list -b nfit_test.0 -F
++ jq -r '.[0].firmware.activate_state'
+ fwa=overflow
+ '[' overflow = overflow ']'
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl update-firmware -b nfit_test.0 -D all
updated 4 nmems.
+ json='[
{
"dev":"nmem1",
"id":"cdab-0a-07e0-feffffff",
"handle":1,
"phys_id":1,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"idle"
}
},
{
"dev":"nmem3",
"id":"cdab-0a-07e0-fefeffff",
"handle":257,
"phys_id":3,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"idle"
}
},
{
"dev":"nmem0",
"id":"cdab-0a-07e0-ffffffff",
"handle":0,
"phys_id":0,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"idle"
}
},
{
"dev":"nmem2",
"id":"cdab-0a-07e0-fffeffff",
"handle":256,
"phys_id":2,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"idle"
}
}
]'
++ jq 'map(select(.firmware.activate_state == "idle")) | length'
+ count=4
+ '[' 4 -eq 4 ']'
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl list -b nfit_test.0 -F
++ jq -r '.[0].firmware.activate_state'
+ fwa=idle
+ '[' idle = idle ']'
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl update-firmware -b nfit_test.0 -A --force all
updated 4 nmems.
+ json='[
{
"dev":"nmem1",
"id":"cdab-0a-07e0-feffffff",
"handle":1,
"phys_id":1,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"armed"
}
},
{
"dev":"nmem3",
"id":"cdab-0a-07e0-fefeffff",
"handle":257,
"phys_id":3,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"armed"
}
},
{
"dev":"nmem0",
"id":"cdab-0a-07e0-ffffffff",
"handle":0,
"phys_id":0,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"armed"
}
},
{
"dev":"nmem2",
"id":"cdab-0a-07e0-fffeffff",
"handle":256,
"phys_id":2,
"security":"disabled",
"firmware":{
"current_version":0,
"can_update":true,
"next_version":281474976689101,
"activate_state":"armed"
}
}
]'
++ jq 'map(select(.firmware.activate_state == "armed")) | length'
+ count=4
+ '[' 4 -eq 4 ']'
++ /root/rpmbuild/BUILD/ndctl-74/build/ndctl/ndctl activate-firmware -v nfit_test.0
libndctl: __sysfs_device_parse: base: '/sys/class/nd' dev: 'ndctl'
libndctl: __sysfs_read_attr: failed to open /sys/class/nd/ndctl0/device/of_node/compatible: No such file or directory
libndctl: __sysfs_device_parse: ndctl0: processed
libndctl: __sysfs_read_attr: failed to open /sys/class/nd/ndctl1/device/of_node/compatible: No such file or directory
libndctl: __sysfs_read_attr: failed to open /sys/class/nd/ndctl1/device/firmware/activate: No such file or directory
libndctl: __sysfs_read_attr: failed to open /sys/class/nd/ndctl1/device/firmware/capability: No such file or directory
libndctl: __sysfs_device_parse: ndctl1: processed
libndctl: __sysfs_device_parse: base: '/sys/devices/platform/nfit_test.0/ndbus0' dev: 'nmem'
libndctl: __util_modalias_to_module: alias: nd:t1 module: libnvdimm
libndctl: parse_dimm_flags: nmem2: label
libndctl: parse_nfit_mem_flags: nmem2: smart_notify
libndctl: __sysfs_device_parse: nmem2: processed
libndctl: __util_modalias_to_module: alias: nd:t1 module: libnvdimm
libndctl: parse_dimm_flags: nmem0: label
libndctl: parse_nfit_mem_flags: nmem0: smart_notify
libndctl: __sysfs_device_parse: nmem0: processed
libndctl: __util_modalias_to_module: alias: nd:t1 module: libnvdimm
libndctl: parse_dimm_flags: nmem3: label
libndctl: parse_nfit_mem_flags: nmem3: smart_notify
libndctl: __sysfs_device_parse: nmem3: processed
libndctl: __util_modalias_to_module: alias: nd:t1 module: libnvdimm
libndctl: parse_dimm_flags: nmem1: label
libndctl: parse_nfit_mem_flags: nmem1: smart_notify
libndctl: __sysfs_device_parse: nmem1: processed
libndctl: write_attr: failed to write quiesce
to /sys/devices/platform/nfit_test.0/ndbus0/firmware/activate: Function not implemented
nfit_test.0: ndbus0: firmware activation failed (Function not implemented)
error activating firmware: Function not implemented
+++ err 65
++++ basename /root/rpmbuild/BUILD/ndctl-74/test/firmware-update.sh
+++ echo test/firmware-update.sh: failed at line 65
+++ '[' -n '' ']'
+++ exit 1
+ json='test/firmware-update.sh: failed at line 65'
++ err 65
+++ basename /root/rpmbuild/BUILD/ndctl-74/test/firmware-update.sh
++ echo test/firmware-update.sh: failed at line 65
++ '[' -n '' ']'
++ exit 1
==============================================================================
Here is the console.log