java equals/hash warnings
gfredericks opened this issue · comments
Should distinct-by have the same warnings about java equals/hash that frequencies-fast and distinct-fast do?
Yes, I suppose it should -- good catch. Or it could just be written in a more efficient Clojurey way and share that between clj and cljs -- basically the cljs implementation with a transient set.
I think I'd prefer the latter option, since otherwise there wouldn't be a well-behaved distinct-by available; shall I make a PR?
Yes, that would be very welcome -- thanks!
Thanks again for the fix!