plstcharles / thelper

Training framework & tools for PyTorch-based machine learning projects.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

pillow possible udpate

fmigneault opened this issue · comments

# PILLOW_VERSION removed which causes import to fail with torchvision
pillow<7

The constant has been re-added because it broke too many code base. We could consider re-applying pillow>=7.1 to get latest updates.
https://pillow.readthedocs.io/en/stable/releasenotes/7.1.0.html#pillow-version-constant

There are a few other changes to consider that could maybe affect some pre-processing:
https://pillow.readthedocs.io/en/stable/releasenotes/7.0.0.html#default-resampling-filter

I don't think other listed changes will impact us.

@plstcharles your call

jeesh, pillow was already not my favorite, this brings my love to a whole new (low) level...

I would rather have pillow>=7.1 than carry around a cursed version forever --- i'll let you push the change in if you want, otherwise i'll put it in the next wave of stuff

If you can slide it in #15, that should be good.

done, will be merged into #15