plotly / falcon

Free, open-source SQL client for Windows and Mac 🦅

Home Page:https://plot.ly/free-sql-client-download/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

don't use Logger inside the connectors

n-riesco opened this issue · comments

At the moment, logging inside connectors is inconsistent:

  • some connectors don't do logging
  • some connectors only log calls to connect

I'd like to move the use of Logger from inside the connectors into https://github.com/plotly/falcon-sql-client/blob/master/backend/persistent/datastores/Datastores.js so that we log:

  • calls to any of the methods exported by Datastores
  • errors thrown inside a connector

FYI @chriddyp @tarzzz