dcc.Input type="color" raises error
luggie opened this issue · comments
dcc.Input(type="color")
is implemented and works correctly. However the components description, doc string (except for on ReadOnly section) and type checking is not up to date as it raises:
Invalid argument `type` passed into Input with ID "set-color-input".
Expected one of ["text","number","password","email","range","search","tel","url","hidden"].
Value provided: "color"
Thanks @luggie (transferred the issue to dash, dcc has been merged in here so the other repo is obsolete)
When you say it's implemented, you mean it works correctly if you disable prop checking? If so, we should be able to just add color as an option here:
dash/components/dash-core-components/src/components/Input.react.js
Lines 221 to 232 in e580ff0
We will want to check on the comment // Only allowing the input types with wide browser compatibility
- perhaps when we first wrote this component color
was poorly supported but now it's close to universal?
One issue with adding the color
prop is that if someone clicks and drags on the color picker, it will fire the callback a bazillion times. Not sure if there is a way to prevent that, or maybe just recommend people use this option in a clientside callback only?
dcc.Input
has a debounce
prop, which should help with that.
When you say it's implemented, you mean it works correctly if you disable prop checking? If so, we should be able to just add color as an option here:
yep, that's what I thought