Rename id argument of callback! to params to match Dash convention
rpkyle opened this issue · comments
Following discussion offline with @alexcjohnson, we should rename the id
argument of callback!
to params
, which aligns with current Dash convention. We already use id
as a property within Dash components, so this usage is potentially confusing as-is.
This is a breaking change in the Dash.jl API, and we should probably make the modification sooner rather than later.
Line 52 in b50e5dc
This likely implies that we should consider renaming CallbackId
to Params
(or SetParams
or Setparms
or setparms
) and callid_str
to params_str
(and, callid
also):
Dash.jl/src/app/supporttypes.jl
Line 3 in b50e5dc
Line 78 in b50e5dc