plotly / Dash.jl

Dash for Julia - A Julia interface to the Dash ecosystem for creating analytic web applications in Julia. No JavaScript required.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename id argument of callback! to params to match Dash convention

rpkyle opened this issue · comments

Following discussion offline with @alexcjohnson, we should rename the id argument of callback! to params, which aligns with current Dash convention. We already use id as a property within Dash components, so this usage is potentially confusing as-is.

This is a breaking change in the Dash.jl API, and we should probably make the modification sooner rather than later.

function callback!(func::Function, app::DashApp, id::CallbackId)

This likely implies that we should consider renaming CallbackId to Params (or SetParams or Setparms or setparms) and callid_str to params_str (and, callid also):

struct CallbackId

macro callid_str(s)