favicon.ico returning 500 in PackageCompiler.jl compiled app
etpinard opened this issue · comments
We've been playing with Dash.jl + PackageCompiler.jl recently and things are working pretty well!
Thanks very much for the efforts that went into #131
One small problem we've encountered has been with the favicon. Currently we get
in the frontend and
on the backend.
I suspect this has to do with the hardcoded path in
which isn't relocatable in PackageCompiler.jl compiled apps.
I'd be willing to submit a PR (or PRs) to fix the problem. I suspect the "best" solution would be to move the favicon in the DashCoreResources repo and replace joinpath(ROOT_PATH, ...) with the corresponding artifact"" statement.
Looking forward to hearing what you have to say here.
Moreover, let me know if you need a reproducible example. I didn't provide one initial as I thought the error logs were enough to pinpoint the bug.
Related #108
Hi!
Yeah, I hadn't thought of that. I'll try to get to the beginning of the trail. weeks to update the resource generator and move favicon to Core Resources