ploomber / core

Core module shared across projects.

Home Page:https://ploomber-core.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

testing

edublancas opened this issue · comments

in #75 I introduced a change to reduce latency when capturing telemetry calls. we had a function that would check internet access by hitting google.com, if it failed, it didn't perform the telemetry call to posthog.

turns out, this was severely affecting performance so I tested what would happen if I removed the call and just make the posthog call regardless of internet status. turns out, nothing happens (calls to posthog don't break if there is no internet connection)

@neelasha23 just to double check, can you perform some testing? try calling the telemetry (log_api) module without internet connection and let me know if you find anything weird

ensure you set the debug flag so the testing events go to the debugging posthog project

Sure, working on this now!

I tired some calls telemetry.log_api(...) with internet on/off multiple times. The calls would have issue_76 mentioned in the action/ metadata. I didn't get any errors. But I dont see any posthog files for 15.8. How to verify ? @edublancas

But I dont see any posthog files for 15.8.

wdym posthog files for 15.8?

shouldn't I be able to access the posthog logs of the calls made by running the posthog-analysis.ipynb file?

no. of the internet was off, the calls get lost (unless you turned it back on before shutting down the python session).

but even in that case, you won't see them because the data ingestion pipeline runs every 24 hours.