plentico / plenti

Static Site Generator with Go backend and Svelte frontend

Home Page:https://plenti.co

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`npm audit fix` breaks build

notramo opened this issue · comments

A security fix breaks the build of the site.

  1. Generate a package lock file by installing a library, e.g. stylus, or just generate it without installing any package: npm i --package-lock-only
    npm will warn you about a security vulnerability found in Svelte
  2. Run npm audit fix
  3. The build fails without explanation. The fix is a minor semver bump, so it shouldn't cause breaking changes.

The error message is nonsense, and even worse, the failed build is served by plenti serve, so it's harder to notice.
I have spent at least an hour debugging it, because I noticed it too late, after I have modifyed bigger amount of code. I couldn't find it with git bisect, because I didn't reinstall the dependencies.

Thanks for flagging this @notramo. Unfortunately upgrading Svelte manually breaks Plenti. This is known issue:

The next big phase for Plenti is improving the compilation step, currently there is much to be desired there.