Giters

plasmabio / tljh-repo2docker

Plugin for The Littlest JupyterHub to build multiple user environments with repo2docker

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

nativeauthenticator's page.html is overshadowed

yamaton opened this issue · comments

commented

Hello, I'm running tljh-repo2docker with Native Authenticator. It runs fine, but some links at the top, "Change Password" and "Authorize Users", are gone.

I suppose this is because page.html in nativeauthenticator is overshadowed by the page.html in tljh-repo2docker.

Here is what you'd see if native authenticator is used alone:

commented

After reading Extending Templates, I figured the {{ super() }} directive is missing in tljh-repo2docker's page.html.

Shall I prepare a PR?

commented

Hello @yamaton thanks for your input.

My understanding of tljh-repo2docker is that authentication is handled externally. So, I'm worried that allowing the Native Authenticator could be problematic with other integrations.

Do you have any thought on this @jtpio?

commented

After reading Extending Templates, I figured the {{ super() }} directive is missing in tljh-repo2docker's page.html.

Ah that could be the case. Thanks @yamaton for catching this, feel free to open a PR to see if that can fix it..