Install docker with corresponding Ubuntu distribution name
pierrepo opened this issue · comments
In docker.yml, the distribution name is hard coded:
- name: Add Docker Repository
apt_repository:
repo: deb https://download.docker.com/linux/ubuntu bionic stable
state: present
bionic corresponds to Ubuntu 18.04. For Ubuntu 20.04, it is focal.
It should be better to have the correct distribution name. If it cannot be detected automaticaly, maybe we could pass the distrib name as server variable in the hosts file.
Maybe ansible_distribution_release variable could do the trick.
Sounds good 👍
Maybe
ansible_distribution_releasevariable could do the trick.
If this variable is available then let's use it. Otherwise it should be possible to retrieve it automatically with an additional Ansible task.
As far as I understood the documentation, this variable is obtained upon the Gathering facts step that is performed every time we run an Ansible playbook.
Of course, this is specific to Ubuntu.
Detecting the version of Ubuntu will also help deal with differences such as the cockpit-docker package mentioned in #128
Oh yes. That's even better!
Of course, this is specific to Ubuntu.
This is also fine since the setup assumes Ubuntu as the OS (same as TLJH).
We are perfectly in line then. Could you handle this issue?
Opened #166