TypeScript doesn't build
PaulBGD opened this issue · comments
PaulBGD commented
Looks like it's due to: DefinitelyTyped/DefinitelyTyped#12942
PaulBGD commented
Oh another issue with the build is that the tasks use an array of AsyncFunctions, which now require 2 generics:
tasks/includes.ts(15,33): error TS2314: Generic type 'AsyncFunction<T, E>' requires 2 type argument(s).
tasks/java.ts(50,22): error TS2314: Generic type 'AsyncFunction<T, E>' requires 2 type argument(s).
tasks/unit_test.ts(9,20): error TS2314: Generic type 'AsyncFunction<T, E>' requires 2 type argument(s).
PaulBGD commented
Looks like a quick fix for both of these issues is to change the typings version for `async: jvilk/BrowserFS#165 (comment)
Just removing the caret (^) from async's version seems to fix this.
John Vilk commented
@PaulBGD is this fixed with your PR? Seems like it is, since the builds are green.
PaulBGD commented
Yep! Thanks for pulling.