[v2.5.0] Question about `relative/absolute` path
The-Lum opened this issue · comments
Here is a issue from:
Just by testing your first example on Online PlantUML servers, as:
@startuml C4_Elements
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml
Person(personAlias, "Label", "Optional Description")
Container(containerAlias, "Label", "Technology", "Optional Description")
System(systemAlias, "Label", "Optional Description")
Rel(personAlias, containerAlias, "Label", "Optional Technology")
@enduml
See output link here.
And on the same topic as your #248:
- Update the !include paths to point to the new release URL
So users that include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/v2.4.0/C4_Component.puml actually get related v2.4.0 files instead of files from master.
When include:
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml
We observe that this line go noway...
Line 5 in d729c55
Perhaps change
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/v2.5.0/C4_Context.puml
to:
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/release/2.5.0/C4_Context.puml
Or fix with other change...
Regards.
I think it's because the tag v2.5.0
doesn't yet exist.
How to make the examples work while you building a new version.... ?
Thanks for your enhancement.
Sorry my fault, I merged the pull request #270 too fast therefore the not released v2.5.0 is referenced
@Potherca: Can you release the v2.5.0 that the branch is fixed, and updated the release text after that?
Or create the tag manually until you create the release that the "mixed master" branch is working again.
@The-Lum: how make the samples working: PlantUML server caches images if the source is not changed and therefore it does not detect the broken path in the included C4_Component.