plantuml-stdlib / C4-PlantUML

C4-PlantUML combines the benefits of PlantUML and the C4 model for providing a simple way of describing and communicate software architectures

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[v2.5.0] Question about `relative/absolute` path

The-Lum opened this issue · comments

Here is a issue from:

Just by testing your first example on Online PlantUML servers, as:

@startuml C4_Elements
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml

Person(personAlias, "Label", "Optional Description")
Container(containerAlias, "Label", "Technology", "Optional Description")
System(systemAlias, "Label", "Optional Description")

Rel(personAlias, containerAlias, "Label", "Optional Technology")
@enduml

See output link here.


And on the same topic as your #248:

When include:

!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml

We observe that this line go noway...

!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/v2.5.0/C4_Context.puml

Perhaps change

!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/v2.5.0/C4_Context.puml

to:

!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/release/2.5.0/C4_Context.puml

Or fix with other change...

Regards.

I think it's because the tag v2.5.0 doesn't yet exist.
How to make the examples work while you building a new version.... ?

Thanks for your enhancement.

Sorry my fault, I merged the pull request #270 too fast therefore the not released v2.5.0 is referenced

@Potherca: Can you release the v2.5.0 that the branch is fixed, and updated the release text after that?
Or create the tag manually until you create the release that the "mixed master" branch is working again.

@The-Lum: how make the samples working: PlantUML server caches images if the source is not changed and therefore it does not detect the broken path in the included C4_Component.

@Potherca: I create a pre-release that the build are working again. Can you please check/update the release notes,...?

@The-Lum: the master branch should work until the finale 2.5.0 release notes... are written

The v2.5.0 tag creation fixes this issue.
Thanks @Potherca, @kirchsth.