planck-repl / planck

Stand-alone ClojureScript REPL

Home Page:https://planck-repl.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

GCL lib analysis issue with ClojureScript master

mfikes opened this issue · comments

For some of the libs in gcl.cljs, the new code in ClojureScript master fails to load them, with the root cause being that they somehow end up with just :url instead of :file:

94d93
<    [goog.date.relativeCommonTests]
191d189
<    [goog.dom.textAssert]
259d256
<    [goog.html.safeUrlTestVectors]
330,332d326
<    [goog.loader.AbstractModuleManager]
<    [goog.loader.AbstractModuleManager.CallbackType]
<    [goog.loader.AbstractModuleManager.FailureType]
335d328
<    [goog.locale.TimeZoneList]
340,342d332
<    [goog.locale.getTimeZoneAllLongNames]
<    [goog.locale.getTimeZoneSelectedLongNames]
<    [goog.locale.getTimeZoneSelectedShortNames]
586d575
<    [goog.string.internal]

This seems to help

$ git diff
diff --git a/planck-cljs/deps.edn b/planck-cljs/deps.edn
index 214f914..2838436 100644
--- a/planck-cljs/deps.edn
+++ b/planck-cljs/deps.edn
@@ -1,4 +1,8 @@
-{:deps {org.clojure/clojurescript {:mvn/version "1.10.520"}
+{:paths ["src"
+         ;; Put GCL on classpath
+         "lib/closure"
+         "lib/third_party/closure"]
+ :deps {org.clojure/clojurescript {:mvn/version "1.10.520"}
         org.clojure/test.check {:mvn/version "0.10.0-alpha4"}
         com.cognitect/transit-cljs {:mvn/version "0.8.256"}
         com.cognitect/transit-js {:mvn/version "0.8.861"}