plaid / plaid-node

Node bindings for Plaid

Home Page:https://plaid.com/docs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing enum value

aditya-arcot opened this issue · comments

This enum SandboxItemFireWebhookRequestWebhookCodeEnum should include LOGIN_REPAIRED as this is a valid webhook code for the sandbox item fire webhook endpoint.

Link to documentation

The documentation is also not in sync for this endpoint.
The endpoint summary section lists LOGIN_REPAIRED as a valid webhook code, but is missing AUTHORIZATION_GRANTED.
The webhook_code specification in the request fields section includes AUTHORIZATION_GRANTED, but not LOGIN_REPAIRED.

commented

@aditya-arcot this is a similar issue to plaid/plaid-java#426 -- the /sandbox/item/fire_webhook endpoint supports only a limited subset of webhook codes. LOGIN_REPAIRED is one of the webhook codes it doesn't support, which is why it is not present in the enum.

LOGIN_REPAIRED is supported by this endpoint, as mentioned in the documentation at the link I provided

The /sandbox/item/fire_webhook endpoint is used to test that code correctly handles webhooks. This endpoint can trigger the following webhooks:
...
LOGIN_REPAIRED: Fired when an Item recovers from the ITEM_LOGIN_REQUIRED without the user going through update mode in your app.

commented

Oops, I missed that! Thanks for the correction. I've submitted a PR to fix this and it should be resolved in the next client library update.

No problem, sounds good