Stirling Feedback
plachenko opened this issue · comments
Fixes to implement from feedback:
- #2 - Made App.vue the main widget component, rather than rendering a primary component
- #3 - Api key in source code
- #4 - Commented out code
- #4 - Inconsistent code formatting
- #4 - Not great variable naming
- #4 - Some unclear calculated values in the template, should be moved into calculated functions with clarifying name
- #5 - A lot of raw CSS - I would prefer to see SASS or a CSS library
- #4 - A lot of code straight in the mounted() function, should be moved into method with clarifying name and called
- #5 - CSS classes are semantic
- #3 - API calls in multiple components, should be extracted into a weatherapi class
- #6 - No tests
- #7 - Limited documentation