pj4533 / OpenPics

An open source iOS application for viewing images from multiple remote sources.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Animation going to image is wrong

pj4533 opened this issue · comments

This is a long standing issue, something to do with older collection view code (read: hacks) after several OS updates. Everytime I go to fix it though, I end up attempting to refactor the world and I never finish.

Maybe take another crack?

I think the way to fix this is to just ditch layout-to-layout transitions, and try to do it another way. Maybe live without cool animations there for a release or two. I need to redo the storyboard anyway to add adaptive layouts (have an old branch of this, but got caught up on cell sizing with layout to layout).

Possibly ditch the collection view for viewing the image? Follow this tutorial to get a good layout: http://www.raywenderlich.com/107439/uicollectionview-custom-layout-tutorial-pinterest then use a control strictly for image viewing like this: https://github.com/suzuki-0000/SKPhotoBrowser

Investigated this more and used IDMPhotoBrowser to create a nice interaction. I need to use the protocol however, not the built in IDMPhoto, cause i want more control over uprezzing of images. I think I should use swift in the rewrite. The SKPhotoBrowser is (almost) a complete port. It does't seem to mimic the protocol exactly, but I can either work around it, or add it. Also SKPhotoBrowser doesn't have a dependency on AFNetworking. Maybe keep that out of the rewrite?