Giters

pixijs / ui

Commonly used UI components for PixiJS

Home Page:https://pixijs.io/ui/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Not full override of destroy method.

gfcrba opened this issue · comments

commented

Hi! While solving a memory issue in my project I've noticed that you ignore 'options' passed to destroy method. And because of this no destroy method on this.list children called.
Expected: you receive options as declared in ancestor and pass it to destroy methods of DisplayObjects you destroy.
https://github.com/pixijs/ui/blob/main/src/ScrollBox.ts#L678