[Suggestion] Change `noExternal` to `external`

Question

finscn opened this issue 8 years ago · comments

Change noExternal to external ,
then change the default value from false to true ,
and change all !args.noExternal to args.external.

'negation-parameter' is not good , I think.

Matt Karl · Answer 1 · Tue Jan 03 2017 05:49:36 GMT+0800 (China Standard Time)

Sounds good. Could you make a PR?

finscn · Answer 2 · Tue Jan 03 2017 06:03:35 GMT+0800 (China Standard Time)

OK. I will

finscn · Answer 3 · Tue Jan 03 2017 06:39:08 GMT+0800 (China Standard Time)

Done after commit ef48a19 .