False positive Github build/test status for 4.14 kernel
benkilimnik opened this issue · comments
Describe the bug
In 2a2349f, many of the 4.14 kernel tests have BPF compilation errors: HINT: bpf_get_current_cgroup_id missing (added in Linux 4.18). GitHub shows these tests as passing despite the failures. As a result, the PR was merged despite the build errors.
To Reproduce
Steps to reproduce the behavior:
- View BPF compilation errors in buildbuddy
Expected behavior
GitHub CI should show failing builds/tests.
Screenshots
This false positive was due to the fact that the BEP upload failed when there were failing tests. This is a case we explicitly ignore the error code for (source).
