pixie-io / pixie

Instant Kubernetes-Native Application Observability

Home Page:https://px.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

UDA Tester `Deserialize` tests merge; should test deserialize

etep opened this issue · comments

In file src/carnot/udf/test_utils.h, the UDF tester class provides a Deserialize method. That method invokes Merge instead of Deserialize. This is probably unintentional; it should, instead, test deserialize.

See:

uda_.Merge(nullptr, other);

Perhaps we should create a new method Merge and update the deserialize method to invoke deserialize instead.