functional tests: phantomjs does not stop
cz8s opened this issue · comments
the functional tests sometimes leave a phantomjs process running that never quits.
I did this change that not necessarily is related with problem, but can help. 5daec6b
Well, me and @mnandri run the functional tests in all environments and the phantomjs process didn't keep running in any of them. I don't know for sure if the problem is solved, but since we couldn't reproduce it to keep investigating it we think pass it to QA and let anyone else try to reproduce the issue.
Just a matter of info: I've changed the tests to only setup the phantomjs before all the tests and kill it after all the tests: 18410b3
saw lots of phantomjs processes on unstable. But it was running an old version without the fix.
Lets see how it looks tomorrow
there was one phantomjs process running on dev today.
everything else was cool.