pixee / codemodder-java

a framework for building java codemods

Home Page:https://codemodder.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Switch order of literals codemod should respect previous null checks

nahsra opened this issue · comments

There has been negative feedback to changes made by this codemod when there is a comparison to null directly previous to the suggested change.

Besides looking inside the method for previous checks, we could also check to see if it's a final class member which has null invariance on assignment.

We could also respect/not report if the data came from a method parameter and has a @NotNull annotation on it.