streamMessage will not raise exception when data is not None but not a dict
vale979 opened this issue · comments
Expected Behaviour
In the method streamMessage inside the DataIngestion class, data
is expected to be a dict. There exists a checking as follows:
if data is None and type(data) != dict:
raise Exception("Require a dictionary to be send for ingestion")
The exception tells the user that it expects data
to be a dictionary.
Actual Behaviour
Rereading the code,
if data is None and type(data) != dict:
raise Exception("Require a dictionary to be send for ingestion")
When data
is not None, no matter what type data
is, that condition will always evaluate to False
, leading to it not raising exception when data is, say, a string.
Reproduce Scenario (including but not limited to)
One potential common pitfall is to type data
as a string instead of a dict.