Add Mode 22 Support

Question

Add Mode 22 Support

malibu1320 opened this issue 8 years ago · comments

malibu1320 commented 8 years ago

Would be nice to work on adding mode 22 support for enhanced PID's. I can assist.

Pires · Answer 1 · Thu Oct 13 2016 03:54:33 GMT+0800 (China Standard Time)

Please, go ahead. github.com/pires/obd-java-api is where it should be implemented.

malibu1320 · Answer 2 · Thu Oct 13 2016 04:00:13 GMT+0800 (China Standard Time)

Do you have any guidance on what needs to be modified? I'm not seeing where the base request header is setup that needs changed. I have the source running locally and connected to my bench PCMs.

Pires · Answer 3 · Thu Oct 13 2016 05:19:24 GMT+0800 (China Standard Time)

Share here what you have and I'll take a look.

malibu1320 · Answer 4 · Thu Oct 13 2016 23:48:38 GMT+0800 (China Standard Time)

Here's an example for GM vs standard OBD. You request on mode $22 with PID "119D". Now I need to see where to adjust analyzing the buffer for a valid response.

public BarometricPressureCommand() {super("01 33");} //Standard OBD PID
public GMBarometricPressureCommand() {super("22 11 9D"); //GM Mode $22 PID

malibu1320 · Answer 5 · Wed Oct 26 2016 01:03:32 GMT+0800 (China Standard Time)

@pires , do you have any tips on how I can implement this? I tried adding new command classes as seen above and adjusting the buffer offset for finding the data but didn't have any luck (yet).

Pires · Answer 6 · Wed Oct 26 2016 01:08:25 GMT+0800 (China Standard Time)

Just override fillBuffer or readRawData, depending on your needs.