pires / android-obd-reader

Android OBD-II Reader application that uses pure OBD-II PID's Java API.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add Acra platform support for crash logging

sytolk opened this issue · comments

I have so many app crashes. After select DTC after start live data with enabled GPS..
Can we include https://github.com/ACRA/acra to have device log?
and this: https://github.com/d-a-n/acra-mailer

I have implemented something similar but in native android development. It creates a log file and asks the user if the log should be mailed.

commented

@Pho3niX90 I am in favor of that solution instead of #138. Anyway, #138 is not ready for testing/merge.

ACRA support sending report by email too
https://github.com/ACRA/acra/wiki/AdvancedUsage#sending-reports-by-email
You can put this preference in settings. But the main advantage that #138 have its that its not need to have Email account (or SMTP) on Android device or Emulator. This is debugging feature (its only for the programmers and @pires can I know what is not ready for you ?) if you not like to debug application with my solution feels free to close PR and write new ACRA project for example ;)

True. But acra is another library that needs to be taken into consideration when compiling. I agree that only developers needs logs, that's why you might as well use android native code and send a complete logcat to the developer.

See here -> #144

Unless acra picks up beter logs than the native android system that I am not aware of ?

@pires you can think about debugging plugins for every kind of developer ;)

commented

@sytolk my comments on why PR #138 is not ready for merge are detailed there.

Regarding plug-ins for logging, it's possible but probably too time-consuming for me right now.