piranha / cyrax

Static site generator

Home Page:http://cyrax.rtfd.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Python 3

cxong opened this issue · comments

commented

Cyrax doesn't work with python 3. When installing it using pip, the following error is returned:

$ pip install -r requirements.txt
Collecting cyrax==2.7 (from -r requirements.txt (line 1))
  Downloading https://files.pythonhosted.org/packages/73/7a/27cb66190a5bd19c41429b77a28ac837d2b1108c692970246d6f9cc931e1/cyrax-2.7.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-1se4ujwz/cyrax/setup.py", line 9, in <module>
        import cyrax
      File "/tmp/pip-build-1se4ujwz/cyrax/cyrax/__init__.py", line 37
        print 'Cyrax', __version__
                    ^
    SyntaxError: Missing parentheses in call to 'print'. Did you mean print(print 'Cyrax', __version__)?

It does not, that's true. :-) It could be done, though. :)

commented

Hmm looks like one of the forks has already made python3 changes. These commits:
memiks@b5bc798
memiks@897fb59

Wonder why they haven't submitted a PR? We could just cherry pick these.

Hmmm... I'm still a little bit uneasy about dropping Python2 support. %)

commented

no, we should be able to support both 2 and 3. With Travis CI it should be easy to check.