add_dependency could cause problems

[Julien Marrec]

github/github_api.gemspec

Lines 22 to 23 in 8702452

 gem.add_dependency 'faraday',     '~> 0.8' 
 gem.add_dependency 'oauth2',      '~> 1.0' 

github_api could pose problems since it requires oauth2 (~> 1.0):

• the latest oauth2 (1.4.4) requires faraday (< 2.0, >= 0.8)
• github_api itself requires faraday (~> 0.8)

In one case I got this:

Bundler could not find compatible versions for gem "faraday":

  In Gemfile:
    github_api (~> 0.18.0) was resolved to 0.18.2, which depends on
      faraday (~> 0.8)

    github_api (~> 0.18.0) was resolved to 0.18.2, which depends on
      oauth2 (~> 1.0) was resolved to 1.4.4, which depends on
        faraday (< 2.0, >= 0.8)

Fixing oauth to 1.4.1 works, and will end up requiring faraday (0.15.4)

[Julien Marrec]

The error I reported makes no sense (someone else reported it to me and I couldn't reproduce), the dependency chain should work as is.

faraday (~> 0.8) and (< 2.0, >= 0.8) should be pretty happy about finding faraday 0.17.3.

I'm closing.