A starless and bible black universe causes segfault at start of game

[Karl F]

(Pardon King Crimson reference in title)

Observed behaviour

Back trace when starting pioneer:

Pioneer loading took 2094.28ms
Info: Creating new galaxy generator 'legacy' version 1
Info: Clearing and re-using previous Galaxy object
Info: StarSystemCache: misses: 0, slave hits: 0, master hits: 0
Info: SectorCache: misses: 101, slave hits: 0, master hits: 1
Info: Created shader starfield (address=0x55555888d4d0)
Info: Created shader skybox (address=0x55555888ca20)
terminate called after throwing an instance of 'std::length_error'
  what():  vector::reserve

Thread 1 "pioneer" received signal SIGABRT, Aborted.
0x00007ffff6eab32c in ?? () from /usr/lib/libc.so.6
(gdb) bt
#0  0x00007ffff6eab32c in ?? () from /usr/lib/libc.so.6
#1  0x00007ffff6e5a6c8 in raise () from /usr/lib/libc.so.6
#2  0x00007ffff6e424b8 in abort () from /usr/lib/libc.so.6
#3  0x00007ffff709ca6f in __gnu_cxx::__verbose_terminate_handler () at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/vterminate.cc:95
#4  0x00007ffff70b011c in __cxxabiv1::__terminate (handler=<optimized out>) at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/eh_terminate.cc:48
#5  0x00007ffff70b0189 in std::terminate () at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/eh_terminate.cc:58
#6  0x00007ffff70b03ed in __cxxabiv1::__cxa_throw (obj=<optimized out>, tinfo=0x7ffff726c0d0 <typeinfo for std::length_error>, 
    dest=0x7ffff70c8580 <std::length_error::~length_error()>) at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/eh_throw.cc:98
#7  0x00007ffff70a01c0 in std::__throw_length_error (__s=__s@entry=0x555555a1946c "vector::reserve") at /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/functexcept.cc:82
#8  0x00005555556b1e45 in std::vector<vector3<float>, std::allocator<vector3<float> > >::reserve (this=this@entry=0x55555b164970, __n=__n@entry=18446744073709549517)
    at /usr/include/c++/13.2.1/bits/vector.tcc:71
#9  0x0000555555712970 in Background::SampleStarsTask::SampleStarsTask (range=..., medianBrightness=@0x555557665af0: 0, stars=..., starsLimit=-2099, info=..., 
    galaxy=..., this=0x5555575a0a30) at /home/me/usr/src/pioneer/src/Background.cpp:272
#10 Background::Starfield::Fill (this=0x5555586b7dc0, rand=..., systemPath=systemPath@entry=0x7fffffffce70, galaxy=...)
    at /home/me/usr/src/pioneer/src/Background.cpp:514
#11 0x000055555577bfb8 in Intro::RefreshBackground (this=this@entry=0x55555ce901f0, r=r@entry=0x555555cf2b70) at /home/me/usr/src/pioneer/src/Intro.cpp:100
#12 0x000055555577cc4e in Intro::Intro (this=this@entry=0x55555ce901f0, r=0x555555cf2b70, width=<optimized out>, height=height@entry=720)
    at /home/me/usr/src/pioneer/src/Intro.cpp:38
#13 0x00005555556079c9 in MainMenu::Start (this=0x555555bc78d0) at /home/me/usr/src/pioneer/src/Pi.cpp:664
#14 0x00005555555dc9b2 in Application::StartLifecycle (this=this@entry=0x555555bc6fb0) at /home/me/usr/src/pioneer/src/core/Application.cpp:118
#15 0x00005555555dce48 in Application::Run (this=0x555555bc6fb0) at /home/me/usr/src/pioneer/src/core/Application.cpp:180
#16 0x00005555555d4786 in main (argc=<optimized out>, argv=<optimized out>) at /home/me/usr/src/pioneer/src/main.cpp:183

Steps to reproduce

Set AmountOfBackgroundStars in config to something low. I have 0.1

My pioneer version (and OS): f3c3aa9

my machine

Vendor ID:               GenuineIntel
  Model name:            12th Gen Intel(R) Core(TM) i7-12700H
    CPU family:          6
    Model:               154
    Thread(s) per core:  2
    Core(s) per socket:  14
    Socket(s):           1
    Stepping:            3