Migrate to pion/webrtc@v3

Question

Migrate to pion/webrtc@v3

Moisesbr opened this issue 4 years ago · comments

I tried adapt these examples for v3 using notes writen by @Sean-Der https://github.com/pion/webrtc/wiki/Release-WebRTC@v3.0.0 , but I'm struggling with gst.CreatePipeline to which depends internal/gstreamer-src and apparently had a some changes to do.
Thanks.

Sean DuBois · Answer 1 · Fri Dec 11 2020 05:20:19 GMT+0800 (China Standard Time)

@Moisesbr that would be amazing! The API for pion/webrtc@v3 is complete, I am just working on closing some final bugs.

Feel free to migrate one example at a time :)

Also when v3.0.0 is tagged I plan on migrating popular projects that import Pion. It will help me understand any oversights I made etc.. would love your help there also!

Moises Marangoni · Answer 2 · Fri Dec 11 2020 20:37:03 GMT+0800 (China Standard Time)

here is my fork for testing purposes, Moisesbr@92ee9b5 my first change example gstreamer-send is not working the sound, running with v2 dependencies work fine, probably I'm missing something, could please give the right direction?

Sean DuBois · Answer 3 · Thu Dec 17 2020 10:54:19 GMT+0800 (China Standard Time)

Hey @Moisesbr

I am ready to take this on. You want to open a PR with your work so far :) I tagged v3.0.0 so now is a great time to do this.

Sean DuBois · Answer 4 · Sat Dec 19 2020 15:22:15 GMT+0800 (China Standard Time)

Fixed with 36cc229