Giters

pinterest / elixometer

A light Elixir wrapper around exometer.

Home Page:https://hexdocs.pm/elixometer

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Release version 1.3.0

jparise opened this issue · comments

commented

This issue tracks progress toward tagging version 1.3.0, including a hex.pm release.

  • Remove lager dependency override. We override exometer's lager dependency for OTP 19+ compatibility, and we can't build a hex.pm package until we remove the override. However ...
  • Upgrade exometer_core. exometer_core no longer uses lager (Feuerlabs/exometer_core#66), but that change hasn't made it into a hex.pm release yet.
commented

A new exometer_core has been released with required changes, and published on hex as v1.5.2. However it's setup dependency fails to build.

commented

The reason to fail build looks like Makefile missing in setup package, see uwiger/setup#41

commented

master now supports exometer_core 1.4 and 1.5 but:

We override exometer's lager dependency for OTP 19+ compatibility, and we can't build a hex.pm package until we remove the override.

Unfortunately to support 1.5 we needed to override another dependency, setup.

To resolve the setup override we need to handle a compiling issue when using the current hex package at uwiger/setup#44. Once this is resolved it will mean a new setup version, likely 1.8.5. Unfortunately exometer_core pins exact version 1.8.4, so we would also need a new release of exometer_core pointing to the new setup version as well. This would move our version requirement to "~> 1.4.0 or ~> 1.5.3 or ~> 1.6" as 1.4.0 pins a different version (1.7.0) of setup.

To resolve the lager override we would either need to drop support for 1.4 (cc @nichochar) or backport the lager fix to an exometer_core 1.4.1. Note that 1.5 introduced a breaking change in Feuerlabs/exometer_core@7a3c1ba and Feuerlabs/exometer_core@9010438. I have not investigated if these changes are likely to hit users or not. This would move our requirement to "~> 1.4.1 or ~> 1.5.3 or ~> 1.6", forcing at least a patch version update on users when they upgrade.

commented

Requiring exometer_core ~> 1.5.2 or ~> 1.6 would ensure no one hits #77.