pinterest / elixometer

A light Elixir wrapper around exometer.

Home Page:https://hexdocs.pm/elixometer

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Erlang 19

supercodepoet opened this issue · comments

Anyone have luck getting this to compile with Erlang 19?

I've got things compiling with Erlang 19. Check out #47

The exometer_core package on hex probably needs updating before it can be merged, though.

@mootpointer does master work for you? We've had luck on our end.

We also had compilation errors with OTP 19.

include/amqp_gen_consumer_spec.hrl:30: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:31: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:32: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:34: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:35: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:36: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:37: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:38: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:39: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:42: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:30: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:31: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:32: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:34: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:35: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:36: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:37: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:38: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:39: syntax error before: '/'
include/amqp_gen_consumer_spec.hrl:42: syntax error before: '/'
Compiling src/amqp_selective_consumer.erl failed:
ERROR: compile failed while processing /Users/zorbash/dev/some_app/deps/amqp_client: rebar_abort
** (Mix) Could not compile dependency :amqp_client, "/Users/zorbash/.asdf/installs/elixir/1.3.3/.mix/rebar compile skip_deps=true deps_dir="/Users/zorbash/dev/some_application/_build/dev/lib"" command failed. You can recompile this dependency with "mix deps.compile amqp_client", update it with "mix deps.update amqp_client" or clean it with "mix deps.clean amqp_client" 

It compiles successfully if you do:

EXOMETER_PACKAGES=minimal
mix deps.get
mix compile

amqp_client is listed in the rebar config of Exometer (see: https://github.com/Feuerlabs/exometer/blob/master/rebar.config#L20).

Exometer uses env variables to configure its dependencies (see: https://github.com/Feuerlabs/exometer#dependency-management)

My understanding is that the rebar compilation script of Exometer =>
https://github.com/Feuerlabs/exometer/blob/master/rebar.config.script#L40

fetches amqp_client and a few more dependencies by default and compiles them.

The version of amqp_client on which Exometer depends on, seems to not be compatible with OTP 19.

Master builds under OTP 18-20 now, and Elixir 1.3 through 1.5 are currently supported.