pinterest / elixometer

A light Elixir wrapper around exometer.

Home Page:https://hexdocs.pm/elixometer

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Question] some calls query for the pid other does not..

linearregression opened this issue · comments

Other calls is querying for the pid using the name, add_counter is not.

File: elixometer/lib/elixometer.ex

defp add_counter(metric_name, ttl_millis) do
    GenServer.cast(__MODULE__, {:add_counter, metric_name, ttl_millis})   <---
 end
def ensure_subscribed(name) do
    if not metric_subscribed?(name) do
      GenServer.call(Process.whereis(__MODULE__), {:subscribe, name})  <---
    end
 end

Just an inconsistency. Elixometer was done early in my Elixir days.

This is an easy fix, submit a PR!

Thanks!