Sample 2 won't work as expected.
jejayhe opened this issue · comments
jejayhe commented
https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugin/src/main/java/com/navercorp/pinpoint/plugin/sample/_02_Injecting_Custom_Interceptor/RecordArgsAndReturnValueInterceptor.java
line110 wouldn't show arg0 in pinpoint-web
since https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugin/src/main/resources/META-INF/pinpoint/type-provider.yml
line5 it only matches code 998.
Do I understand that right?
Jaehong Kim commented
@jejayhe
Modified the sample.
recorder.recordApi(descriptor);
recorder.recordAttribute(SamplePluginConstants.ANNOTATION_KEY_MY_VALUE, arg0);