enhancement: Replace main screenshot of code with common/copyable code
bigpick opened this issue · comments
Info
If there was a general block of code that could be used for consistency across different ports, I think that'd be a good idea, to have at least somewhat of a basis to base appearance off of. Or, at the very least, so that each port has the same amount of demonstrated code/syntax highlighting.
I tried searching around for the code in the main repo's readme, but it seems like it must be private code/in a private repo somewhere. What do you think about replacing it with a screenshot of a new common block of code (and then also uploading that block of code(s) in a sample/ type folder as well)?
Down the road, could have multiple languages, etc.. but having at least one or two sizable chunks of common code that could be used across various ports would be nice imo.
This is a good idea. Definitely cross linked with the screenshots issue, wanna get more screenshots in here in general
+1 on a sample/ folder, especially for JavaScript, TypeScript, and Python.
I reference this file a lot while discussing JavaScript syntax, since I think it contains all the dynamic colors in Spaceduck. What do you think about adding this to the sample folder?
I wanna change that orange to turquoise and the brackets away from purple in that image. I don’t like the colors, despite them being all represented 😖
perhaps the function parameters too :/
How about I put this code into a sample/ folder and push it to the dev branch so we are both using the same file to test new syntax colors?
I guess I was thinking something more like an idea, that would be aside to copy/implement across multiple languages, but having something at least copyable for now would be a start
I don’t wanna have any users install testing code when they use this plugin. Do you know if there’s a git way to have this separate, or should there be another repo or something? I have a local folder of random syntax files that I’ve been using for personal use.
I don’t wanna have any users install testing code when they use this plugin
So, this is specifically talking about just the vim port then, yeah?
One way, would be to have a spare repo under the org (+1 for another org usecase;)), and it'd just be something like samples so like spaceduck-theme/samples and in it would just be a bunch of various languages that we have consistent/similar files showing a medium chunk sized of code, to demonstrate what a language looks like.
Then, in whatever port, for the "demo" screenshot(s), you just copy+paste one/some examples from that repo, for demonstrative purposes. But the port has no knowledge of that code, its just something you do temporarily to get the screenshot. So like, you could have a main screenshot in the spaceduck-theme/spaceduck-vim repo that is in vim, it's just the same code the maintainer of the theme copy/pasted from one of the sample files when they made the screenshot(s) for the port. That covers the specific vim/plugin case, where users don't have to install code snippets as part of a port, but also makes it so that all ports should have a consistent set of code/files to be able to choose from to "demo" for screenshots.
Lol made an org and invited you guys 😛 🚀
@pineapplegiant cool, thanks. Can join, but think still need permissions to do anything for now. fwiw, I was thinking something like
spaceduck-theme
├── atom-syntax # port
│ ├── README.md
│ ├── ...
├── atom-ui # port
│ ├── ...
├── samples # port
│ ├── code.js
│ ├── code.json
│ ├── ...
│ └── code.py
├── slack # port
│ ├── ...
├── spaceduck
│ ├── README.md
│ ├── color_syntax_specification.md
│ ├── ...
├── spaceduck-site
│ ├── ...
...
└── vim # port
where spaceduck-theme/spaceduck would be your top level "🚀 🦆 An intergalactic space theme for Vim, Terminal, and more!" landing repo, and then you have your ports/site/w.e else under it
Yeah I think you're on the money that makes sense 🧠