pimutils / vdirsyncer

📇 Synchronize calendars and contacts.

Home Page:https://vdirsyncer.pimutils.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adjusted error handling on one-sided sync

mkrecek234 opened this issue · comments

I noticed that vDirSyncer sometimes has issues with certain CalDAV calendar events; maybe they are not fully CalDAV compliant, or SabreDAV does not support some features, for example I often get

  • Unknown media type
  • COUNT IN RRULE not a positive integer or
  • This recurrence rule does not generate any valid instances.

If the source calendar is configured as read_only then it would be highly beneficial to create the target event even if there are fragments not supported, for example it creates an event but skips the "unknown media type" info.

Behaviour today:

  • All events with whatever error are skipped and do not show up
  • vDirSyncer will re-try on each and every sync again to process the VEVENT, with always the same error

Expected behaviour:

  • Events with errors are still created, but with stripped content, and eventually a remark in the notes field.

Not syncing events then at all is a bigger issue as appointments get lost, even if otherwise only an unsupported attachment would be deleted.

commented

Generally, our policy is to sync items even if they are invalid (otherwise how do get you them out to fix them!?).

So yeah, this is a bug, but I've to refresh my mind on why we needed to parse RRULE and COUNT