[Bug]: collapsible_controls doesn't work when state is "standby"
CarterBrehm opened this issue · comments
Current Behavior
Currently, setting collapsible_controls: true on a mushroom media player card doesn't collapse the controls when the state of the media_player is standby.
Expected Behavior
Since standby is equivalent to off, the controls do not work and should instead be hidden, as if the media_player was off.
Steps To Reproduce
My environment is a Insignia Roku TV, connected to home assistant using the built-in Roku integration. It never reports the TV as off, so the collapsible controls never function.
Environment
- OS: Ubuntu Server 16.04
- Browser: Safari/Firefox (tested on both, no change)
- Frontend Version: 20220531.0 - latest
- Core Version: 2022.6.0Anything else?
No response
Is it still standby once the TV is turned on?
No, once the Roku TV is on, it behaves as normal:
I think all that needs to be changed is the hardcoded values that dictate when the collapsible controls show. For example, on line 109 in utils.ts, there's a line that checks if the control should show by seeing if state === off, I think this is solved by changing that to a simple state === off || state === standby.
It will be fixed with the 2.3.1 version available tomorrow with HA 2022.11 release